New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long [code][/code] tags and other content could break out of the #34
Conversation
posteare div. Fixed with setting width of .posteare to 75%.
Hmm, isn't this a hack? Hard coding some random width means it only fixes one instance of the problem, not all. . |
auto is making stuff bad again. :auto seems to be a fix for IE6, but fucking who cares about IE6? Not me. If really needed, an @if block should do it.
I don't really know much about CSS so I can't provide a better solution. |
In Google Chrome 51.0.2704.106, setting the width of the postarea to 0 also limits the element to the bounds of the container, so it may not be necessary to specify a width of 75%. I haven't tested this with any other browsers, though. |
That would be a good starting point to test, though. A width of '0' 2016-07-18 16:09 GMT+02:00 Nelson Gomez notifications@github.com:
|
@Nao @C3realGuy Just did some tests and width: 0 for .postarea works fine in IE9+, Firefox 45, Chrome, Safari 5.1 and Opera 36 from what I can tell. |
Setting width: inherit is doing it for me too. I have no idea which way is the best, changed it to the solution by @nsgomez, looked best for me. |
@C3realGuy, who the heck is CiderJack..? I'm seeing him in the commit log, not you? @nsgomez, nice low-poly avatar. Did you make it yourself, or is there some online tool available to make those..? (Also... Always nice to see a Wedge user ;)) |
@Nao no idea who CiderJack is, but this is because i didn't set a email address on my local git config. Don't ask me why it's not just using my github username/address... |
So, is this name your nickname in some respect, but unrelated to the account identified by GH..? |
No, completely unrelated. Didn't set GIT_AUTHOR_NAME nor GIT_AUTHOR_EMAIL. That's causing the trouble. I'm going to change the commits. |
posteare div. Fixed with setting width of .posteare to 75%.
auto is making stuff bad again. :auto seems to be a fix for IE6, but fucking who cares about IE6? Not me. If really needed, an @if block should do it.
…into dev_cssoverflow
…into dev_cssoverflow
…into dev_cssoverflow
At least the user name and email should be correct. Bad commit history, don't merge this PR, better just commit the changes on your own. Otherwise I have to open a new PR or do some rebase stuff. Git is sometimes some sort of a |
I've opened pull request #35 to keep the fixed commit history while getting rid of the merge messages, so it'd be easier to merge that. |
postarea div. Fixed with setting width of .posteare to 75%.