Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set scrub_data to True by default. #7

Merged
merged 2 commits into from Jan 7, 2014
Merged

Conversation

rgbkrk
Copy link
Contributor

@rgbkrk rgbkrk commented Dec 30, 2013

Considering all the outcry in fog/fog#2525, fog/fog#2526, HackerNews and on Twitter, let's just change this to scrub data by default.

People don't always use the optional arguments, but in this case they should. If they want the speed up from not scrubbing data, they can set it to False (as they have to do in Fog as well now).

@mpdehaan
Copy link

+1

@rgbkrk
Copy link
Contributor Author

rgbkrk commented Dec 31, 2013

Apparently the DigitalOcean API only accepts 1 as true (...just following the fog PR).

I'll update this in a second.

@zbal
Copy link
Member

zbal commented Jan 7, 2014

Thanks.
I'll publish to pypi shortly.

zbal added a commit that referenced this pull request Jan 7, 2014
Set scrub_data to True by default.
@zbal zbal merged commit b1e22dc into Wiredcraft:master Jan 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants