Edit Site: prevent inserter overscroll

[mattwiebe]

Description

This just adds some overflow: hidden to .interface-interface-skeleton__left-sidebar to prevent it overflowing when open. It seems a bit too simple and may break something else, but since I believe we're already expecting overflows to be hidden (as in #26424), I hope there aren't any larger issues.

BONUS: the block inserter tip at the bottom is no longer cut off

fixes #26428

How has this been tested?

• Open Site Editor
• Open the Inserter sidebar
• See if there's a giant white space when you scroll down to the bottom of the Site Editor proper (not just the Inserter itself)
• See if the tooltip

Screenshots

Before

^ Colorized green by me, normally white. Note the double scrollbars.

After

Types of changes

Bug fix

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[david-szabo97]

Tests well! I have one very minor request. See my comment abpve.

[Copons]

I've noticed that the editor's scrollbar gets cut off by the footer as well.
What about:

.interface-interface-skeleton__body {
	// ...
	@include break-medium() {
		padding-bottom: $button-size-small + $border-width;
	}
}

.interface-interface-skeleton__left-sidebar {
	@include break-medium() {
		// ...
		overflow: hidden;
	}
}

---

Also please make sure to test on the post editor as well, since these changes affect that too.
(I've tested it and I haven't seen any regressions, but just in case 🙂 )

[mattwiebe]

Thanks @Copons - better to deal with this on the body like you say.

Also please make sure to test on the post editor as well, since these changes affect that too.

Yup, tested in there, everything seems unaffected.

[david-szabo97]

Post editor ✅ Site editor ✅ Chrome ✅ Firefox ✅ Safari ✅ Ship it? ✅ 🚢

[github-actions]

Congratulations on your first merged pull request, @mattwiebe! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

[talldan]

This was shipped in 5.6.1, so removing the backport label:
https://make.wordpress.org/core/2021/01/28/wordpress-5-6-1-rc1/