Fix: Font size picker does not correctly handles big font sizes. #26705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
jorgefilipecosta
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +22 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
kjellr
approved these changes
Nov 4, 2020
jorgefilipecosta
deleted the
fix/font-size-picker-does-not-correctly-handles-big-font-sizes
branch
talldan
added
the
Backport to WP Minor Release
|
This was mentioned again here - #27606. Seems like we forgot to add the backport label to this so it missed WordPress 5.6. I've added the label to backport it to 5.6.1 whenever that might be. |
whyisjake
pushed a commit
that referenced
this pull request
Jan 28, 2021
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Jan 28, 2021
These are backports coming for the 5.6.1 release. Summary of the following issues: * [#27970](WordPress/gutenberg#27970) - Fix editor crash when registering a block pattern without `categories` Backport to WP Minor Release [Feature] Inserter [Feature] Patterns [Type] Bug * [#27733](WordPress/gutenberg#27733) - [Embed block]: Add html and reusable support back Backport to WP Minor Release [Block] Embed [Type] Regression * [#27727](WordPress/gutenberg#27727) - Add aria labels to box control component inputs/button Backport to WP Minor Release [Feature] UI Components [Package] Components [Type] Bug [a11y] Labelling * [#27627](WordPress/gutenberg#27627) - HTML Block: Fix editor styles Backport to WP Minor Release [Block] HTML [Type] Regression * [#27526](WordPress/gutenberg#27526) - Core Data: Normalize `_fields` value for use in `stableKey` Backport to WP Minor Release [Package] Core data [Type] Bug * [#26705](WordPress/gutenberg#26705) - Fix: Font size picker does not correctly handles big font sizes. Backport to WP Minor Release [Type] Bug * [#26432](WordPress/gutenberg#26432) - Edit Site: prevent inserter overscroll Backport to WP Minor Release First-time Contributor [Feature] Full Site Editing [Type] Bug Packages updated: @wordpress/block-directory@1.17.7 @wordpress/block-editor@5.1.6 @wordpress/block-library@2.26.7 @wordpress/components@11.1.4 @wordpress/core-data@2.24.3 @wordpress/edit-post@3.25.7 @wordpress/edit-site@1.15.7 @wordpress/edit-widgets@1.1.7 @wordpress/editor@9.24.6 @wordpress/format-library@1.25.6 @wordpress/interface@0.10.7 @wordpress/list-reusable-blocks@1.24.4 @wordpress/nux@3.23.4 @wordpress/reusable-blocks@1.0.6 @wordpress/server-side-render@1.19.4 Fixes #52391. Props gziolo, whyisjake. git-svn-id: https://develop.svn.wordpress.org/branches/5.6@50061 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jan 28, 2021
These are backports coming for the 5.6.1 release. Summary of the following issues: * [#27970](WordPress/gutenberg#27970) - Fix editor crash when registering a block pattern without `categories` Backport to WP Minor Release [Feature] Inserter [Feature] Patterns [Type] Bug * [#27733](WordPress/gutenberg#27733) - [Embed block]: Add html and reusable support back Backport to WP Minor Release [Block] Embed [Type] Regression * [#27727](WordPress/gutenberg#27727) - Add aria labels to box control component inputs/button Backport to WP Minor Release [Feature] UI Components [Package] Components [Type] Bug [a11y] Labelling * [#27627](WordPress/gutenberg#27627) - HTML Block: Fix editor styles Backport to WP Minor Release [Block] HTML [Type] Regression * [#27526](WordPress/gutenberg#27526) - Core Data: Normalize `_fields` value for use in `stableKey` Backport to WP Minor Release [Package] Core data [Type] Bug * [#26705](WordPress/gutenberg#26705) - Fix: Font size picker does not correctly handles big font sizes. Backport to WP Minor Release [Type] Bug * [#26432](WordPress/gutenberg#26432) - Edit Site: prevent inserter overscroll Backport to WP Minor Release First-time Contributor [Feature] Full Site Editing [Type] Bug Packages updated: @wordpress/block-directory@1.17.7 @wordpress/block-editor@5.1.6 @wordpress/block-library@2.26.7 @wordpress/components@11.1.4 @wordpress/core-data@2.24.3 @wordpress/edit-post@3.25.7 @wordpress/edit-site@1.15.7 @wordpress/edit-widgets@1.1.7 @wordpress/editor@9.24.6 @wordpress/format-library@1.25.6 @wordpress/interface@0.10.7 @wordpress/list-reusable-blocks@1.24.4 @wordpress/nux@3.23.4 @wordpress/reusable-blocks@1.0.6 @wordpress/server-side-render@1.19.4 Fixes #52391. Props gziolo, whyisjake. Built from https://develop.svn.wordpress.org/branches/5.6@50061 git-svn-id: http://core.svn.wordpress.org/branches/5.6@49762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Jan 28, 2021
These are backports coming for the 5.6.1 release. Summary of the following issues: * [#27970](WordPress/gutenberg#27970) - Fix editor crash when registering a block pattern without `categories` Backport to WP Minor Release [Feature] Inserter [Feature] Patterns [Type] Bug * [#27733](WordPress/gutenberg#27733) - [Embed block]: Add html and reusable support back Backport to WP Minor Release [Block] Embed [Type] Regression * [#27727](WordPress/gutenberg#27727) - Add aria labels to box control component inputs/button Backport to WP Minor Release [Feature] UI Components [Package] Components [Type] Bug [a11y] Labelling * [#27627](WordPress/gutenberg#27627) - HTML Block: Fix editor styles Backport to WP Minor Release [Block] HTML [Type] Regression * [#27526](WordPress/gutenberg#27526) - Core Data: Normalize `_fields` value for use in `stableKey` Backport to WP Minor Release [Package] Core data [Type] Bug * [#26705](WordPress/gutenberg#26705) - Fix: Font size picker does not correctly handles big font sizes. Backport to WP Minor Release [Type] Bug * [#26432](WordPress/gutenberg#26432) - Edit Site: prevent inserter overscroll Backport to WP Minor Release First-time Contributor [Feature] Full Site Editing [Type] Bug Packages updated: @wordpress/block-directory@1.17.7 @wordpress/block-editor@5.1.6 @wordpress/block-library@2.26.7 @wordpress/components@11.1.4 @wordpress/core-data@2.24.3 @wordpress/edit-post@3.25.7 @wordpress/edit-site@1.15.7 @wordpress/edit-widgets@1.1.7 @wordpress/editor@9.24.6 @wordpress/format-library@1.25.6 @wordpress/interface@0.10.7 @wordpress/list-reusable-blocks@1.24.4 @wordpress/nux@3.23.4 @wordpress/reusable-blocks@1.0.6 @wordpress/server-side-render@1.19.4 Fixes #52391. Props gziolo, whyisjake. Built from https://develop.svn.wordpress.org/branches/5.6@50061 git-svn-id: https://core.svn.wordpress.org/branches/5.6@49762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
After updating to WordPress 5.6.1, the text size setting for paragraph blocks is no longer reflected. All options are displayed at the same size, and the default is selected no matter which one I choose. Undoing this pull request change will allow you to select correctly.
|
|
Same problem here. |
6 tasks
|
This was shipped in 5.6.1, so removing the backport label: |
talldan
removed
the
Backport to WP Minor Release
VenusPR
added a commit
to VenusPR/Wordpress_Richard
that referenced
this pull request
Mar 9, 2023
These are backports coming for the 5.6.1 release. Summary of the following issues: * [#27970](WordPress/gutenberg#27970) - Fix editor crash when registering a block pattern without `categories` Backport to WP Minor Release [Feature] Inserter [Feature] Patterns [Type] Bug * [#27733](WordPress/gutenberg#27733) - [Embed block]: Add html and reusable support back Backport to WP Minor Release [Block] Embed [Type] Regression * [#27727](WordPress/gutenberg#27727) - Add aria labels to box control component inputs/button Backport to WP Minor Release [Feature] UI Components [Package] Components [Type] Bug [a11y] Labelling * [#27627](WordPress/gutenberg#27627) - HTML Block: Fix editor styles Backport to WP Minor Release [Block] HTML [Type] Regression * [#27526](WordPress/gutenberg#27526) - Core Data: Normalize `_fields` value for use in `stableKey` Backport to WP Minor Release [Package] Core data [Type] Bug * [#26705](WordPress/gutenberg#26705) - Fix: Font size picker does not correctly handles big font sizes. Backport to WP Minor Release [Type] Bug * [#26432](WordPress/gutenberg#26432) - Edit Site: prevent inserter overscroll Backport to WP Minor Release First-time Contributor [Feature] Full Site Editing [Type] Bug Packages updated: @wordpress/block-directory@1.17.7 @wordpress/block-editor@5.1.6 @wordpress/block-library@2.26.7 @wordpress/components@11.1.4 @wordpress/core-data@2.24.3 @wordpress/edit-post@3.25.7 @wordpress/edit-site@1.15.7 @wordpress/edit-widgets@1.1.7 @wordpress/editor@9.24.6 @wordpress/format-library@1.25.6 @wordpress/interface@0.10.7 @wordpress/list-reusable-blocks@1.24.4 @wordpress/nux@3.23.4 @wordpress/reusable-blocks@1.0.6 @wordpress/server-side-render@1.19.4 Fixes #52391. Props gziolo, whyisjake. Built from https://develop.svn.wordpress.org/branches/5.6@50061 git-svn-id: http://core.svn.wordpress.org/branches/5.6@49762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25862
Makes the font size picker selector not render any font size with a size bigger than 25px.
Before:
After: