Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try: Fix notices below block toolbars. #32238

Merged
merged 1 commit into from Jun 2, 2021
Merged

Try: Fix notices below block toolbars. #32238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/base-styles/_z-index.scss
View file
Open in desktop
Expand Up @@ -114,10 +114,6 @@ $z-layers: (
// Show the FSE template previews above the editor and any open block toolbars
".edit-site-navigation-panel__preview": 32,

// Show notices below expanded editor bar
// .edit-post-header { z-index: 30 }
".components-notice-list": 29,

// Above the block list and the header.
".block-editor-block-list__block-popover": 31,

Expand Down
1 change: 0 additions & 1 deletion packages/components/src/notice/style.scss
View file
Open in desktop
Expand Up @@ -76,7 +76,6 @@
// The notice should never be wider than the viewport, or the close button might be hidden. Especially relevant at high zoom levels. Related to https://core.trac.wordpress.org/ticket/47603#ticket.
max-width: 100vw;
box-sizing: border-box;
z-index: z-index(".components-notice-list");

.components-notice__content {
margin-top: $grid-unit-15;
Expand Down
14 changes: 2 additions & 12 deletions packages/editor/src/components/editor-notices/style.scss
View file
Open in desktop
@@ -1,22 +1,12 @@
// Dismissible notices.
.components-editor-notices__dismissible {
position: sticky;
top: 0;
right: 0;
color: $gray-900;
}

// Non-dismissible notices.
// Dismissible & non-dismissible notices.
.components-editor-notices__dismissible,
.components-editor-notices__pinned {
position: relative;
left: 0;
top: 0;
right: 0;
color: $gray-900;
}

.components-editor-notices__dismissible,
.components-editor-notices__pinned {
.components-notice {
box-sizing: border-box;
margin: 0;
Expand Down