Dunfell xilinx staging2

[karthikpoduval]

No description provided.

[cbrake]

I'm not sure if this will be generally compatible with all machines -- will defer to @kraj

[kraj]

this should be ok since, it is doing the default setup, so no change for normal operations. But it offers a nice way to override it when needed. So I am ok with this change

[cbrake]

that looks better, as options are only set for Xilinx machines. thoughts @kraj ?

[kraj]

if these options are only being used for single machine zcu102-zynqmp then better place for this is machine config file but if its SOC family settings then it makes sense here.

[karthikpoduval]

@kraj do you mean in meta-xilinx/meta-xilinx-bsp/conf/machine/zcu102-zynqmp.conf ? But that would be a pull request for the xilinx giuthub.

[kraj]

right

[karthikpoduval]

if these options are only being used for single machine zcu102-zynqmp then better place for this is machine config file but if its SOC family settings then it makes sense here.

@kraj
I haven't tried other SoC's from Xilinx but they may require this change too, I don't want to assume without trying. On a separate note, is wildcard possible here ? Something like.
PREFERRED_PROVIDER_virtual/dtb_*-zynqmp = "device-tree"

[kraj]

I don't think wildcard work in such cases and its also not a good idea, since you want to be particular about it.

[karthikpoduval]

right

I looked a bit closer, it looks like Xilinx sets PREFERRED_PROVIDER_virtual/pmu-firmware, PREFERRED_PROVIDER_virtual/boot-bin and PREFERRED_PROVIDER_virtual/dtb in their petalinux distro
https://github.com/Xilinx/meta-petalinux/blob/master/conf/distro/include/petalinux-features.conf#L34

So I tried to build using DISTRO=petalinux bitbake petalinux-image-minimal
but the petalinux distro is including the poky distro.
https://github.com/Xilinx/meta-petalinux/blob/master/conf/distro/petalinux.conf#L1

however poky distro isn't being provided by Yoe workspace in my understanding.
Not sure how to proceed, kindly advise

If build with petalinux distro then then following variable don't need to be set.
PREFERRED_PROVIDER_virtual/pmu-firmware, PREFERRED_PROVIDER_virtual/boot-bin and PREFERRED_PROVIDER_virtual/dtb

[cbrake]

I'm not sure best how to handle the poky requirement ... it is my opinion that distros should not require poky -- that severely limits the portability of the layer.

This brings up a more basic question -- should we support multiple distros in the Yoe directory structure? I don't see any reason offhand why we can't -- simply remove meta-yoe from the layers -- however, we then loose many of the nice yoe defaults ...

[kraj]

these are all machine specific settings, so they should either be in machine config file or perhaps user specific local.conf

[kraj]

I think its hard-coding paths here perhaps a bug in our layer adding tool but please replace it with ${TOPDIR}

[karthikpoduval]

Good catch, it looks like the very next patch in the series fixed it to ${TOPDIR} (looks like yoe_/bitbake- scripts did the magic. Should I squash all the xilinx related patches to one ? Also should these be moved to BSPLAYERS instead of BBLAYERS ? If yes then the rockchip layer should be moved too. Please confirm.

[kraj]

I think just squash the one which fixes the above issue into one. Rest seem to be ok