Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pre upgrade message #671

Merged
merged 1 commit into from Mar 9, 2024
Merged

fix pre upgrade message #671

merged 1 commit into from Mar 9, 2024

Conversation

OniriCorpe
Copy link
Member

Problem

  • the actual pre upgrade message is showed in any case, however it is not relevant if already in version 28

Solution

  • move it to doc/PRE_UPGRADE.d and rename it 28.0.3~ynh1.md

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

@OniriCorpe OniriCorpe changed the base branch from master to testing February 29, 2024 20:26
@alexAubin
Copy link
Member

Eeeeh yeah but the thing is that we'll want this for every major version ... I guess we can duplicate it once 29.x, 30.x, etc will be out, but people jumping multiple major version will have it displayed multiple times ... But yeah the link to the forum topic is related to 28.x so meh idk watdo

@OniriCorpe
Copy link
Member Author

there is not one major version a week, it's fine i guess x)

@alexAubin
Copy link
Member

Actually nevermind, once 29.x is out we can just edit+rename the PRE_UPGRADE file such that it's only shown when upgrading to the new major version so it's fine

@ericgaspar ericgaspar merged commit fde839d into testing Mar 9, 2024
@ericgaspar ericgaspar deleted the fix-upgrade-message branch March 9, 2024 09:49
@ericgaspar ericgaspar mentioned this pull request Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants