- clear menuDelegate in case of an error in MENUDEF parsing.

ZDoom · Jan 20, 2023 · a570e77 · a570e77
1 parent acfca3f
commit a570e77
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/source/common/menu/menu.cpp b/source/common/menu/menu.cpp
@@ -924,10 +924,16 @@ void M_Init (void)
 	}
 	catch (CVMAbortException &err)
 	{
+		menuDelegate = nullptr;
 		err.MaybePrintMessage();
 		Printf(PRINT_NONOTIFY | PRINT_BOLD, "%s", err.stacktrace.GetChars());
 		I_FatalError("Failed to initialize menus");
 	}
+	catch (...)
+	{
+		menuDelegate = nullptr;
+		throw;
+	}
 	M_CreateMenus();
 }
 

diff --git a/source/common/menu/menudef.cpp b/source/common/menu/menudef.cpp
@@ -150,13 +150,13 @@ void DeinitMenus()
 			pair->Value = nullptr;
 		}
 	}
-	MenuDescriptors.Clear();
-	OptionValues.Clear();
 	if (menuDelegate)
 	{
 		menuDelegate->Destroy();
 		menuDelegate = nullptr;
 	}
+	MenuDescriptors.Clear();
+	OptionValues.Clear();
 }
 
 FTextureID GetMenuTexture(const char* const name)