Fixed read beyond buffer boundary during font color parsing

Printing of string that ends with '\c' led to undefined behavior Example: 'echo \c' in console
ZDoom · Sep 23, 2017 · f174111 · f174111
1 parent 7892142
commit f174111
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/v_font.cpp b/src/v_font.cpp
@@ -2666,7 +2666,7 @@ EColorRange V_ParseFontColor (const uint8_t *&color_value, int normalcolor, int
 	}
 	else							// Incomplete!
 	{
-		color_value = ch - (*ch == '\0');
+		color_value = ch - (newcolor == '\0');
 		return CR_UNDEFINED;
 	}
 	color_value = ch;
@@ -2772,4 +2772,4 @@ DEFINE_ACTION_FUNCTION(FFont, GetCursor)
 {
 	PARAM_SELF_STRUCT_PROLOGUE(FFont);
 	ACTION_RETURN_STRING(FString(self->GetCursor()));
-}
+}