Worldpay: Encyrpted ApplePay and GooglePay #5093
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aenand
reviewed
Apr 25, 2024
No unfortunately |
aenand
reviewed
Apr 25, 2024
| @@ -981,7 +1000,15 @@ def payment_details(payment_method, options = {}) | |||
| when String | |||
| token_type_and_details(payment_method) | |||
| else | |||
| type = network_token?(payment_method) || options[:wallet_type] == :google_pay ? :network_token : :credit | |||
| type = if network_token?(payment_method) || options[:wallet_type] == :google_pay | |||
There was a problem hiding this comment.
Is there a way to not have nested if statements here? Can we put another case for NetworkTokenizationCreditCard?
There was a problem hiding this comment.
I'll update it a bit but I can't change it to NetworkTokenizationCreditCard because network_token?(payment_method) was added by Shopify and I don't want to break an integration
almalee24
force-pushed
the
worldpay_encrypted_apple_google_pay
branch
from
dac72a6
to
e23e6ba
Compare
aenand
reviewed
Apr 25, 2024
Comment on lines
+1003
to
+1011
| type = if network_token?(payment_method) | ||
| payment_method.payment_data ? :encrypted_wallet : :network_token | ||
| else | ||
| options[:wallet_type] == :google_pay ? :network_token : :credit | ||
| end |
There was a problem hiding this comment.
Do payment methods with options[:wallet_type] == :google_pay have payment_data? would this work?
Suggested change
| type = if network_token?(payment_method) | |
| payment_method.payment_data ? :encrypted_wallet : :network_token | |
| else | |
| options[:wallet_type] == :google_pay ? :network_token : :credit | |
| end | |
| type = if network_token?(payment_method) || options[:wallet_type] == :google_pay | |
| payment_method.payment_data ? :encrypted_wallet : :network_token | |
| else | |
| :credit | |
| end |
There was a problem hiding this comment.
It doesn't. options[:wallet_type] == :google_pay is for a non-tokenized GooglePay which we treat as a CreditCard
aenand
approved these changes
Apr 25, 2024
Add support for encrypted ApplePay and GooglePay.
almalee24
force-pushed
the
worldpay_encrypted_apple_google_pay
branch
from
e23e6ba
to
65fde2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for encrypted ApplePay and GooglePay.