Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatrans: First implementation #5099

Merged
merged 1 commit into from Apr 30, 2024

Conversation

gasb150
Copy link
Collaborator

@gasb150 gasb150 commented Apr 18, 2024

Summary:

Adding Datatrans gateway with support for basic functionality including authorize, purchase, capture, refund and void. Scrubbing method. Unit and remote tests.
SER-1193

Tests

Remote Test:
Finished in 18.393965 seconds.
15 tests, 43 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 100% passed

Unit Tests:
19 tests, 45 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

RuboCop:
795 files inspected, no offenses detected

@gasb150 gasb150 marked this pull request as draft April 18, 2024 15:34
@gasb150 gasb150 force-pushed the SER-1193_Datatrans_first_implementation branch 4 times, most recently from 71a5b69 to a026506 Compare April 19, 2024 21:11
Copy link
Collaborator

@Heavyblade Heavyblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a really good starting point @gasb150

test/unit/gateways/datatrans_test.rb Show resolved Hide resolved
test/remote/gateways/remote_datatrans_test.rb Show resolved Hide resolved
test/remote/gateways/remote_datatrans_test.rb Show resolved Hide resolved
test/remote/gateways/remote_datatrans_test.rb Show resolved Hide resolved
test/remote/gateways/remote_datatrans_test.rb Show resolved Hide resolved
@gasb150 gasb150 force-pushed the SER-1193_Datatrans_first_implementation branch 2 times, most recently from e026e45 to a8287d3 Compare April 22, 2024 15:14
@gasb150 gasb150 marked this pull request as ready for review April 22, 2024 15:19
@gasb150 gasb150 requested a review from naashton April 22, 2024 17:28
@gasb150 gasb150 marked this pull request as draft April 22, 2024 17:30
@gasb150 gasb150 force-pushed the SER-1193_Datatrans_first_implementation branch 2 times, most recently from f7b52dd to a1416c6 Compare April 26, 2024 23:26
@gasb150 gasb150 marked this pull request as ready for review April 26, 2024 23:26
Summary:
-----
Adding Datatrans gateway with support for basic functionality including authorize, purchase, capture, refund and void.
Scrubbing method. Unit and remote tests.
[SER-1193](https://spreedly.atlassian.net/browse/SER-1193)

Tests
-----
Remote Test:
Finished in 18.393965 seconds.
15 tests, 43 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
100% passed

Unit Tests:
19 tests, 45 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

RuboCop:
795 files inspected, no offenses detected
@Heavyblade Heavyblade force-pushed the SER-1193_Datatrans_first_implementation branch from a1416c6 to 30b2dc3 Compare April 30, 2024 17:30
@Heavyblade Heavyblade merged commit 732e89b into master Apr 30, 2024
0 of 5 checks passed
@Heavyblade Heavyblade deleted the SER-1193_Datatrans_first_implementation branch April 30, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants