Upgrade ruby 3.1 #5104
Upgrade ruby 3.1 #5104
Conversation
DustinHaefele
force-pushed
the
upgrade-ruby-3.1
branch
3 times, most recently
from
8cad1fa
to
bc01a04
Compare
|
Could you add the results for Alelo remote tests? |
|
@almalee24 I'm working on getting some alelo credentials to do the remote tests but I can say that the alelo unit tests fail on Ruby 3.1 with 7 OpenSSL errors if I don't update Jose to 1.2.0, but if I do update to 1.2.0 they all pass. Ruby 3.1 and Jose 1.1.3 Ruby 3.1 and Jose 1.2.0 |
DustinHaefele
force-pushed
the
upgrade-ruby-3.1
branch
from
bc01a04
to
300520c
Compare
| @@ -44,7 +44,7 @@ def test_unsuccessful_signing_request | |||
| assert gateway.options[:private_key] | |||
| assert auth = gateway.authorize(@amount, @credit_card, @options) | |||
| assert_failure auth | |||
| assert_equal 'Neither PUB key nor PRIV key: not enough data', auth.message | |||
| assert_equal 'Neither PUB key nor PRIV key: unsupported', auth.message | |||
There was a problem hiding this comment.
This is a new error message based on the openssl updates from the new JOSE version.
| @@ -147,15 +147,15 @@ def test_failed_verify | |||
| @declined_card.number = '' | |||
| response = @gateway.verify(@declined_card, @options) | |||
| assert_failure response | |||
| assert_match %r{PAN Must be >= 13 Digits}, response.message | |||
| assert_match %r{PAN Must be >= 12 Digits}, response.message | |||
There was a problem hiding this comment.
Both of the changes in this file are just updated error messaging from creditcall.
| @@ -4,7 +4,7 @@ class RemoteDLocalTest < Test::Unit::TestCase | |||
| def setup | |||
| @gateway = DLocalGateway.new(fixtures(:d_local)) | |||
|
|
|||
| @amount = 200 | |||
| @amount = 1000 | |||
There was a problem hiding this comment.
A bunch of tests were failing with "Amount too low" so I bumped this up.
| @@ -160,7 +160,7 @@ def test_successful_verify | |||
| def test_failed_verify | |||
| assert response = @gateway_auth.verify(@declined_card, @options) | |||
| assert_failure response | |||
| assert_equal 'missing: fraud_detection', response.message | |||
| assert_equal '10734: Fraud Detection Data is required', response.message | |||
There was a problem hiding this comment.
another new error message from the gateway
| @@ -60,7 +60,7 @@ def test_successful_purchase | |||
|
|
|||
| def test_failed_purchase | |||
| assert purchase = @gateway.purchase(@success_amount, @expired_card, @options) | |||
| assert_match 'Card has expired', purchase.message | |||
| assert_match 'Transaction declined', purchase.message | |||
There was a problem hiding this comment.
Another new error message.
DustinHaefele
force-pushed
the
upgrade-ruby-3.1
branch
2 times, most recently
from
49a9918
to
24f3433
Compare
|
Alright here is the summary of results for the remote tests with both ruby 2.7 and ruby 3.1. 47 gateways - I could not connect to for either unexplained reasons with their sandbox or lack of credentials. 89 gateways - the remote tests had the same exact passing and failing tests in both versions of ruby. 2 gateways - had other issues detailed below
|
DustinHaefele
force-pushed
the
upgrade-ruby-3.1
branch
from
3f9b9a2
to
4d14e2c
Compare
| @@ -2,6 +2,8 @@ | |||
| = ActiveMerchant CHANGELOG | |||
|
|
|||
| == HEAD | |||
|
|
|||
| == Version 1.136.0 (May 1, 2024) | |||
There was a problem hiding this comment.
Did you release a new version?
There was a problem hiding this comment.
It is an AC on the ticket to do so. I haven't pushed the tag or done the release yet though. I was going to do that in my CAB release window.
There was a problem hiding this comment.
Ah gotcha. You should probably cut a new version before merging this and then have this in it's own
There was a problem hiding this comment.
Yeah that makes sense to me I'll update before merging this change.
No description provided.