Datatrans: NT, AP, GP support #5110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasb150
force-pushed
the
SER-1193_Datatrans_first_implementation
branch
from
f7b52dd
to
a1416c6
Compare
gasb150
force-pushed
the
SER-1195_Datatrans_AP_GP_NT
branch
from
1fcffc9
to
053902b
Compare
Heavyblade
force-pushed
the
SER-1193_Datatrans_first_implementation
branch
from
a1416c6
to
30b2dc3
Compare
Base automatically changed from
SER-1193_Datatrans_first_implementation
to
master
April 30, 2024 17:32
gasb150
force-pushed
the
SER-1195_Datatrans_AP_GP_NT
branch
4 times, most recently
from
d6230be
to
3a11181
Compare
Heavyblade
reviewed
May 3, 2024
There was a problem hiding this comment.
@gasb150 looks pretty much ok, there some comments for your consideration
gasb150
force-pushed
the
SER-1195_Datatrans_AP_GP_NT
branch
from
3a11181
to
18af313
Compare
Summary:
-----
This PR includes for Datatrans the
NetworkToken, ApplePay and GooglePay code
to perform transactions with that PM
[SER-1195](https://spreedly.atlassian.net/browse/SER-1195)
Tests
-----
Remote Test:
Finished in 23.393965 seconds.
19 tests, 51 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
100% passed
Unit Tests:
23 tests, 111 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
RuboCop:
795 files inspected, no offenses detected
gasb150
force-pushed
the
SER-1195_Datatrans_AP_GP_NT
branch
from
18af313
to
2cc3176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR includes for Datatrans the
NetworkToken, ApplePay and GooglePay code
to perform transactions with that PM
SER-1195
Tests
Remote Test:
Finished in 23.393965 seconds.
19 tests, 51 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 100% passed
Unit Tests:
23 tests, 111 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
RuboCop:
795 files inspected, no offenses detected