Paymentez: Updates success_from method #5116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case action | ||
| when 'refund' | ||
| successful_current_status = transaction_current_status&.upcase == 'CANCELLED' && request_status&.downcase == 'success' | ||
| successful_current_status || default_response |
There was a problem hiding this comment.
If current_status = "APPROVED" and request_status = "failure" it looks to me like this would be marked as successful because on line 297 success status would inclued "APPROVED" but my understanding is for a refund this combo should be failed. Is that right?
There was a problem hiding this comment.
Ah that's a good point, let me add some validations. I'm don't think that response should be returned but if it's is it's good to add some validations to prevent some false positives
almalee24
force-pushed
the
paymentez_update_success_from
branch
2 times, most recently
from
48549db
to
0553701
Compare
almalee24
force-pushed
the
paymentez_update_success_from
branch
from
0553701
to
44a8d4e
Compare
almalee24
force-pushed
the
paymentez_update_success_from
branch
from
44a8d4e
to
f561824
Compare
Update success_from method to take current_status for the first message to evaluate. If the transaction type is refund the successful current_status base on CANCELLED if status is also success Remote 34 tests, 85 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit 33 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
almalee24
force-pushed
the
paymentez_update_success_from
branch
from
f561824
to
e85fd16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update success_from method to take current_status for the first message to evaluate.
If the transaction type is refund the successful current_status base
on CANCELLED if status is also success
Remote
34 tests, 85 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Unit
33 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed