HiPay: Fix parse authorization string #5119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasb150
requested changes
May 9, 2024
javierpedrozaing
force-pushed
the
SER-1235_HiPay_fix_authorization_string
branch
from
877ac11
to
cee6068
Compare
javierpedrozaing
force-pushed
the
SER-1235_HiPay_fix_authorization_string
branch
from
cee6068
to
0378112
Compare
naashton
force-pushed
the
SER-1235_HiPay_fix_authorization_string
branch
from
e0e467b
to
ffbcbe4
Compare
Description ------------------------- This commit fixes the parse authorization string when the first value is nil also fixes a issue trying to get the payment_method.brand when the payment method is not a credit card Unit test ------------------------- Finished in 0.800901 seconds. 23 tests, 59 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 28.72 tests/s, 73.67 assertions/s Remote test ------------------------- Finished in 9.141401 seconds. 1 tests, 6 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 0.11 tests/s, 0.66 assertions/s Rubocop ------------------------- 795 files inspected, no offenses detected
naashton
force-pushed
the
SER-1235_HiPay_fix_authorization_string
branch
from
ffbcbe4
to
09d30af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit fixes the parse authorization string when the first value is nil also fixes a issue trying to get the payment_method.brand when the payment method is not a credit card
Unit test
Finished in 0.800901 seconds.
23 tests, 59 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
28.72 tests/s, 73.67 assertions/s
Remote test
Finished in 9.141401 seconds.
1 tests, 6 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
0.11 tests/s, 0.66 assertions/s
Rubocop
795 files inspected, no offenses detected