Fix compiler warnings #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @ladyada |
ladyada
reviewed
Mar 28, 2024
src/NMEA_build.cpp
Outdated
| (char *)malloc(len + 3); // +2 for \r\n, +1 for null terminator | ||
| if (newStr) { | ||
| strcpy(newStr, nmea); // Copy original string | ||
| strcat(newStr, "\r\n"); // Append \r\n |
There was a problem hiding this comment.
newstr is never used after this and we return nmea so this code does not actually append \r\n to nmea?
There was a problem hiding this comment.
Thanks, I'll take another look at the code.
|
@ladyada could I get another review? Thanks. |
ladyada
requested changes
Apr 1, 2024
src/NMEA_build.cpp
Outdated
| if (nmeaWithCRLF) { | ||
| strcpy(nmeaWithCRLF, nmea); // Copy original string | ||
| strcat(nmeaWithCRLF, "\r\n"); // Append \r\n | ||
| return nmeaWithCRLF; // return pointer to finished product |
There was a problem hiding this comment.
we need to return the same buffer, so strcpy it back and free the temp buff
|
I added the suggested fix, but didn't tag you again @ladyada. |
ladyada
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.