Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort rss feed with newest at top #1355

Merged
merged 1 commit into from Mar 21, 2024
Merged

Conversation

FoamyGuy
Copy link
Contributor

resolves #1354

After this change there were two devices showing up at the top of the list (out of chronological order) It turns out the date parsing format is very specific, it needs 4 digit years and zero padded single digits, with those changes these devices now get put into the proper place of the order.

Worth considering breaking out the Blinka boards as a separate feed. Right now they effectively get rendered one after another in the same giant RSS feed. This means they won't ever appear at the top of the feed for any RSS client that doesn't do it's own sorting locally on pubDate. Or another option is to try to intermix them into 1 list, and then sort that and render it as the RSS feed, I'm not certain if it's possible but can check into it if that is something that other folks think is a good way to do it.

Copy link
Contributor

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The change of the date on the tdisplay shouldn't be necessary and there are probably many more boards without the leading 0.

@makermelissa makermelissa merged commit 3d69327 into adafruit:main Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RSS Board Feed not showing most recent boards first
2 participants