Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the use of hyphens in glyph names #1362

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

iterumllc
Copy link
Collaborator

@iterumllc iterumllc commented May 17, 2021

Description

Having hyphens at the end of "development" glyph names makes handling ranges correctly in the grammar significantly trickier; the current implementation doesn't attempt to. As there doesn't seem to be a need for them in that location this PR updates the docs to clarify that they can't end a name.

Perhaps more controversially it also states that the special characters can't be used at the start of a name. The spec was ambiguous about this but the featgram.g implementation doesn't allow them at the beginning of a name. I agree with that decision—too dicey to allow them there.

One additional question is whether we should go farther and restrict the use of more or all of the special characters at the end of a name. The main reason for doing that would be to reserve potential glyph operators for future use, which could be handled the way hyphens are handled now. I leave that up for discussion.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Closes #970

@skef
Copy link
Collaborator

skef commented Jul 31, 2023

I'll update this and assign @kaydeearts soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[spec] Outdated statements about glyph classes
2 participants