feat: global availability block #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
fkakatie
changed the title
kptdobe
approved these changes
May 23, 2024
| setTimeout(() => { | ||
| if (svg.dataset.auto === 'true') unfocusPin(tooltip, svg); | ||
| setTimeout(() => { | ||
| iterateThroughPins(pins, svg, tooltip, randomIndex); // recursive call to focus another pin |
There was a problem hiding this comment.
This creates an infinite loop.
Writing some minimal doc to explain the method would help understand this is expected and desired.
blocks/availability/availability.js
Outdated
| return randomIndex; | ||
| } | ||
|
|
||
| function tooltipAfterOverride(tooltip, axis, pixels) { |
There was a problem hiding this comment.
This method contains a lot of maths, but it is not obvious what it is doing or why it is needed...
blocks/availability/availability.js
Outdated
| import { createTag } from '../../scripts/scripts.js'; | ||
|
|
||
| function generateRandomNumber(max, excluding) { | ||
| // minimum is inclusive, maximum is exclusive |
There was a problem hiding this comment.
No minimum... ? What is excluding ?
kptdobe
approved these changes
May 27, 2024
trieloff
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
more dynamic map of global availability
How Has This Been Tested?
https://avail-block--helix-website--adobe.aem.page/drafts/fkakatie/global
Types of changes
Checklist: