Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of deprecated scipy.integrate function #159

Merged
merged 2 commits into from May 4, 2024

Conversation

aidanmontare-fed
Copy link
Contributor

@aidanmontare-fed aidanmontare-fed commented May 3, 2024

switch from scipy.integrate.simps to scipy.integrate.simpson

scipy.integrate.simps was deprecated in scipy 1.12.0 and will be removed in 1.14 (the upcoming minor version number).

https://docs.scipy.org/doc/scipy/release/1.12.0-notes.html#deprecated-features

This does introduce a requirement of scipy>=1.6.0, which is when scipy.integrate.simpson was introduced

https://docs.scipy.org/doc/scipy/release/1.6.0-notes.html#scipy-integrate-improvements

We could use a conditional import if we want compatability with older versions?

scipy.integrate.simps was deprecated in scipy 1.12.0 and will be removed in 1.14
https://docs.scipy.org/doc/scipy/release/1.12.0-notes.html#deprecated-features

This does introduce a requirement of scipy>=1.6.0, which is when scipy.integrate.simpson was introduced
https://docs.scipy.org/doc/scipy/release/1.6.0-notes.html#scipy-integrate-improvements
@coveralls
Copy link

Coverage Status

coverage: 89.396% (-2.7%) from 92.13%
when pulling bb55557 on aidanmontare-fed:fix-deprecated-simpson
into 8faefa9 on aewallin:master.

@aewallin
Copy link
Owner

aewallin commented May 4, 2024

scipy 1.6.0 release date seems to be around 2020? I guess the >=1.6.0 requirement doesn't affect that many users..

@aewallin aewallin merged commit 3787eb5 into aewallin:master May 4, 2024
11 checks passed
@aidanmontare-fed aidanmontare-fed deleted the fix-deprecated-simpson branch May 6, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants