Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add activities info to workout samples #352

Open
wants to merge 8 commits into
base: swift
Choose a base branch
from

Conversation

thalysviana
Copy link
Collaborator

Description

This PR includes the following changes:

  • Adds workout activity support. Now it's possible to fetch activity information from samples and save these activities on newly created workouts
  • Adds support to multiple activities in a single workout. (E.g. swimBikeRun)

Fixes #

Fixes issue with SwimBikeRun, Transition, UnderwaterDiving raw values. Updated their values to the correct ones and added the new UnderwaterDiving case.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings

@thalysviana thalysviana added bug Something isn't working enhancement New feature or request labels Nov 29, 2023
@thalysviana thalysviana self-assigned this Nov 29, 2023
Copy link
Collaborator

@GGGava GGGava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, amazing job man, thank you very much :)

For the next PRs can you please add some testing instructions? Some HK documentation links would also be amazing.

Non-blocking: Could you take a quick look at what is the effort to add activity filters for the workout queries? (last section of this). If it's quick & easy, could be nice to add this to this PR, but if it would take some time, please add a reminder on the project board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants