Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation and tests for returns #222

Merged
merged 4 commits into from Apr 9, 2024
Merged

Add documentation and tests for returns #222

merged 4 commits into from Apr 9, 2024

Conversation

HKuz
Copy link
Collaborator

@HKuz HKuz commented Mar 21, 2024

Addresses #124

  • Documentation: adds a screen shot and write-up for returns against purchase invoices in a Check Run
  • tests

@HKuz HKuz changed the title docs: add screen shot and explanation around returns Draft: add documentation and tests for returns Mar 21, 2024
@HKuz HKuz linked an issue Mar 21, 2024 that may be closed by this pull request
@agritheory
Copy link
Owner

@HKuz There's a test suit branch which has some of the strategies for this

@agritheory agritheory marked this pull request as draft March 22, 2024 00:18
@agritheory agritheory changed the title Draft: add documentation and tests for returns Add documentation and tests for returns Mar 22, 2024
@HKuz
Copy link
Collaborator Author

HKuz commented Mar 22, 2024

@agritheory - good call. I ended up copying over the conftest.py file and used your tests as a base. I had to make a few tweaks to get them to pass - namely splitting up the error test and the functionality tests for both the on-hold invoice and the returns (the CR wouldn't persist after the error test), then I had to make sure only a draft CR was returned in the fixture since we're using it more than once now.

This passes when I run pytest locally but we'll need the CI changes plus the recent v15 test workflow updates for it to pass CI.

@agritheory agritheory self-requested a review April 3, 2024 14:43
@agritheory agritheory marked this pull request as ready for review April 3, 2024 14:43
@agritheory
Copy link
Owner

@HKuz I think this PR is the right one to remove the cypress tests.

@HKuz
Copy link
Collaborator Author

HKuz commented Apr 4, 2024

@agritheory - yup, makes sense to have the CI actually run the new tests... All set and passing 👍

@agritheory agritheory merged commit 48bd0c2 into version-14 Apr 9, 2024
5 checks passed
@agritheory agritheory deleted the cn_docs branch April 9, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests and documentation for handling credit notes
2 participants