POC for opening an app inside of a modal

[ajnart]

This is a POC, is it is not meant to be merged

This allows opening apps inside of an iframe that's roughly the size of the window

Need to be addressed

• Some websites can't be opened in iframes
• The size of the window should be changed
• The animation should "pop" slowly out of the app where it's coming from
• Changing apps quickly shows the content of the previous modal
• The modal should not be unmounted, allowing the user to quickly jump between apps
• We should change the behavior settings to be a toggle between "open in same window" / "open in new window" / "open in iframe"

From discord https://www.w3schools.com/tags/att_iframe_sandbox.asp

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	17.79%	4540 / 25508
🔵	Statements	17.79%	4540 / 25508
🔵	Functions	6.71%	28 / 417
🔵	Branches	38.98%	115 / 295

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/components/Dashboard/Tiles/Apps/AppTile.tsx	17.46%	100%	0%	17.46%	19-130, 133-157

Generated in workflow #4772

[vishalkadam7]

have a look a this is useful for iframe, extra feature
https://github.com/verlok/vanilla-lazyload

[ajnart]

have a look a this is useful for iframe, extra feature verlok/vanilla-lazyload

Thanks for the link but I'm not sure how it can apply. I think the issues I was facing were more related to some kind of ID management with the modals, the iFrames are not loaded when the page opens but on the click of the apps

[vishalkadam7]

even I'm not sure how it works, instead of modals a full screen iframe within the homarr dashboard on a click of the apps might work, try if that is possible. I'll look for some other links if I find I'll share

[vishalkadam7]

not sure but look for X-Frame-Options SAMEORIGIN