Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add dns disable timer #2029

Merged
merged 9 commits into from May 23, 2024
Merged

Conversation

hillaliy
Copy link
Contributor

@hillaliy hillaliy commented Apr 26, 2024

Category

Feature

Overview

Add timer to disable dns

Issue Number

Related issue: #2026

Screenshot

Screenshot 2024-04-26 at 19 16 49

@dslatt
Copy link
Contributor

dslatt commented Apr 27, 2024

looks good.

2 things I noticed.

1 - translation isn't working
Screenshot from 2024-04-27 07-36-15

2 - trying to disable an individual integration from widget seems to disable both.

@hillaliy
Copy link
Contributor Author

hillaliy commented Apr 27, 2024

I'll check it.

@hillaliy
Copy link
Contributor Author

Screenshot 2024-04-28 at 17 39 14

@hillaliy
Copy link
Contributor Author

I install PiHole on my test server. Everything work as expected.

@dslatt
Copy link
Contributor

dslatt commented Apr 28, 2024

everything works for me too

@manuel-rw
Copy link
Collaborator

wrong field, sorry :)

@hillaliy
Copy link
Contributor Author

hillaliy commented Apr 30, 2024

New design with @tag inspiration 😀

Screenshot 2024-04-30 at 20 19 11 Screenshot 2024-04-30 at 20 19 29

@dslatt
Copy link
Contributor

dslatt commented Apr 30, 2024

Looks great 😃 with the changes

src/widgets/dnshole/DnsHoleControls.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@SeDemal SeDemal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for some, up to you on others.
Looks really great already though, timer definitely was missing, it's a great addition.

src/widgets/dnshole/DnsHoleControls.tsx Outdated Show resolved Hide resolved
src/widgets/dnshole/DnsHoleControls.tsx Show resolved Hide resolved
src/widgets/dnshole/DnsHoleControls.tsx Show resolved Hide resolved
src/widgets/dnshole/DnsHoleControls.tsx Outdated Show resolved Hide resolved
src/widgets/dnshole/DnsHoleControls.tsx Show resolved Hide resolved
src/widgets/dnshole/TimerModal.tsx Outdated Show resolved Hide resolved
src/widgets/dnshole/TimerModal.tsx Outdated Show resolved Hide resolved
@manuel-rw manuel-rw merged commit afdca50 into ajnart:dev May 23, 2024
2 checks passed
@hillaliy hillaliy deleted the dns-controls-timer branch May 23, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants