-Wuseless-action #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akimd
force-pushed
the
master
branch
2 times, most recently
from
18346d3
to
1161649
Compare
akimd
force-pushed
the
master
branch
3 times, most recently
from
b7dafab
to
54c5d5d
Compare
akimd
force-pushed
the
master
branch
2 times, most recently
from
18ce4bc
to
6dca1eb
Compare
* src/complain.h, src/complain.c: Add support for -Wuseless-action.
* tests/glr-regression.at, tests/java.at, tests/torture.at, * examples/c/lexcalc/parse.y, examples/c/reccalc/parse.y: here. * src/parse-gram.y: Likewise. Style changes.
In order for the useless chain productions to work properly, there should not be actions that make explicit the default behavior. * src/scan-code.l (strspacecmp, useless_default_action): New. (translate_action): Report useless actions. * src/reader.c (grammar_rule_check_and_complete): Don't trigger this warning when generating explicit actions for C++. * tests/actions.at (Useless default actions): New.
* doc/bison.texi, src/getargs.c, NEWS: here.
akimd
force-pushed
the
master
branch
2 times, most recently
from
ba596de
to
88bd814
Compare
akimd
force-pushed
the
master
branch
6 times, most recently
from
3a24da1
to
f9b3606
Compare
akimd
force-pushed
the
master
branch
2 times, most recently
from
734eb80
to
66706a7
Compare
|
@akimd: Was there a reason to not include this in one of the last releases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
-Wuseless-actionto warn about rules with a useless{ $$ = $1; }action.