Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better defaults for shell scripts #6

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

BaldPolnareff
Copy link

No description provided.

al12gamer and others added 7 commits December 27, 2023 23:28
change resolution for newer GPD Win Mini
rename to fedora
prep for gpd win mini detection
added git reminder
…, as well as better default resolution of the bash environment, just some good practices
@BaldPolnareff
Copy link
Author

I just added a couple of better defaults for the shell scripts:

  1. #!/usr/bin/env bash is usually recommended over hardcoding #!/bin/bash as some systems may have bash in different places, this trick should resolve the env with the right path to bash in general
  2. set -euo pipefail guarantees running in strict mode, in case uncaught errors occur, the scripts will exit at the failure point, rather than continuing executing the rest of the script

@al12gamer
Copy link
Owner

Thanks for these! Any other suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants