Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickfix, replaces thumbnail_url with polymorphic_url #394

Closed

Conversation

wiesion
Copy link

@wiesion wiesion commented Mar 13, 2021

As described in rails/rails#15840 - *_path methods should not be allowed within Mailer actions.

The original code is in fact constructing an absolute URL, but is doing so by making using of a *_path method.
This is fine for web and data views, but not for Mailer views.

Rails' polymorphic_url exists since Version 2 and its syntax experienced no changes, so i assume it should be a backward compatible replacement.

@wiesion
Copy link
Author

wiesion commented Mar 13, 2021

This should also address the issues #383 and #388.

@lauer
Copy link

lauer commented May 4, 2023

thy not just use return thumbnail_url(thumb)
that works fine for me?

@alexbevi
Copy link
Owner

alexbevi commented May 4, 2023

Closing this in favour of #406

@alexbevi alexbevi closed this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants