Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add no_data argument to augment arg check #21

Closed

Conversation

malcolmbarrett
Copy link
Contributor

check_arguments checks that augment methods have a data argument when strict = TRUE, but as discussed in softloud/metabroom#15, rma methods don't use data. This PR adds an argument to override the data requirement for augment while keeping other strict requirements. I'm not sure if this is the best approach (vs. deleting that requirement), but let me know what you think.

Also addresses a test result in tidymodels/broom#674

@alexpghayes
Copy link
Owner

I would prefer using strict = FALSE in the tests and documenting why with a short comment there.

@malcolmbarrett
Copy link
Contributor Author

Sounds reasonable! I'll update on tidymodels/broom#674

@malcolmbarrett malcolmbarrett deleted the augment-data branch April 7, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants