add no_data argument to augment arg check #21
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_arguments
checks thataugment
methods have adata
argument whenstrict = TRUE
, but as discussed in softloud/metabroom#15,rma
methods don't use data. This PR adds an argument to override thedata
requirement foraugment
while keeping other strict requirements. I'm not sure if this is the best approach (vs. deleting that requirement), but let me know what you think.Also addresses a test result in tidymodels/broom#674