Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support consumer subscribe multiple topics #2729

Open
wants to merge 4 commits into
base: 2.2.x-ospp2023
Choose a base branch
from

Conversation

LeBW
Copy link
Contributor

@LeBW LeBW commented Aug 25, 2022

Describe what this PR does / why we need it

For now, the consumer can only subscribe one topic (destination).
Sometimes we need to subscribe multiple topics in one consumer (which is also one consumer binding in SCA).

In this PR, we can subscribe multiple topics in one consumer binding.

Does this pull request fix one issue?

Part of #2712.

Describe how to use it

  1. Set multiplex in ConsumerProperties to true.
  2. Write multiple topics in the destination with comma seperated, e.g., topic-1,topic-2.
  3. The consumer binding will subscribe multiple topics.

Special notes for reviews

@steverao
Copy link
Collaborator

I didn't see the field of multiplex in your PR. Don't we need to set the field in ConsumerProperties

@LeBW LeBW force-pushed the feature-rocketmq-consumer-multiple-destination branch from 48e081b to 9bbefe5 Compare December 24, 2022 14:28
@LeBW
Copy link
Contributor Author

LeBW commented Dec 27, 2022

I didn't see the field of multiplex in your PR. Don't we need to set the field in ConsumerProperties

multiplex should be set by the user in the application.yml if they want to enable this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants