Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GA4 focus loss tracker to /world and /government/organisations #3573

Merged
merged 1 commit into from Mar 21, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Mar 21, 2024

What

  • Adds the ga4-focus-loss-tracker to /world and /government/organisations filter inputs

Why

@AshGDS AshGDS requested a review from andysellick March 21, 2024 13:51
@AshGDS AshGDS self-assigned this Mar 21, 2024
@govuk-ci govuk-ci temporarily deployed to collections-pr-3573 March 21, 2024 13:51 Inactive
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

event_name: "filter",
type: "filter",
action: "filter",
section: @presented_index.title
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also force this to use the English translation string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andysellick I don't think so as it seems to come from the content item:

app/controllers/world_controller.rb

class WorldController < ApplicationController
  def index
    index = WorldIndex.find!("/world")
    @presented_index = WorldIndexPresenter.new(index)
    setup_content_item_and_navigation_helpers(index)
  end
end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks for checking 👍

@AshGDS AshGDS merged commit 82a8262 into main Mar 21, 2024
18 checks passed
@AshGDS AshGDS deleted the ga4-add-focus-loss-tracker branch March 21, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants