[WIP] Add homepage card variant #3611
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinJJones
force-pushed
the
add-homepage-card-variant
branch
from
2f7ffe8
to
724cc37
Compare
Adds chevron-card from `frontend`, the view template and styles have been changed slightly to ensure it still works as expecting when used in collections. the main differences are: - Allow custom heading levels to be used - `data_attributes` now passed in from the parent view template, this matches the current behaviour - Ensure card content has a max-width of two thirds on desktop devices
MartinJJones
force-pushed
the
add-homepage-card-variant
branch
from
724cc37
to
04628e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add homepage card variant
Why
Trello card
Follow these steps if you are doing a Rails upgrade.