Change GA4 confirm form action data #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change the value of
actionfor the GA4 event on the 'Confirm you want to get emails' page fromConfirmtoconfirm.This was using an existing value from the locale file but this is also used for the visible button text. Given the choice between creating a new entry in the locale file just for this, and simply hard coding it, I went with hard coding on the basis that this isn't text that needs translating - in fact it should always be just
confirmfor the GA4 data.Why
GA4 event data values like this should normally be lowercase.
Visual changes
None.
Trello card: https://trello.com/c/JDJgPslu/805-lowercase-confirm-action-in-email-subscription-journey