Use govuk-frontend v5 #2989
Draft
Use govuk-frontend v5 #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpatrickpatrick
force-pushed
the
use-govuk-frontend-v5
branch
from
00fbcac
to
c8b446d
Compare
patrickpatrickpatrick
force-pushed
the
use-govuk-frontend-v5
branch
from
c8b446d
to
a193195
Compare
patrickpatrickpatrick
force-pushed
the
use-govuk-frontend-v5
branch
from
a193195
to
fd85855
Compare
jon-kirwan
force-pushed
the
use-govuk-frontend-v5
branch
4 times, most recently
from
9016f95
to
9dc9a2a
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
jon-kirwan
force-pushed
the
use-govuk-frontend-v5
branch
from
9dc9a2a
to
befbd14
Compare
MartinJJones
force-pushed
the
use-govuk-frontend-v5
branch
from
65d938c
to
343ec30
Compare
MartinJJones
force-pushed
the
use-govuk-frontend-v5
branch
from
343ec30
to
e8eba12
Compare
In govuk-frontend v5, the `init` function is now called when a module is created. This meant changing how the `initAll()` function works in govuk_publishing_components so that it does not call `init()` when initialising components JavaScript. It also meant moving `init` functions in components to the constructor to bring them in line with the new way of initialising.
govuk_publishing_components has govuk-frontend as a dependency. govuk-frontend v5 now targets browsers that support ES6. This means that the UMD modules used in govuk_publsihing_components from govuk-frontend use features of ES6 and so it means that Uglifier can't be used anymore because it only supports ES5. As well as installing terser and updating the config, this commit also contains a patch for getting terser working. Sprockets doesn't have an built-in loader for terser so we need to add this functionality.
To prevent browsers evaluating JS that isn't supported, components that contain code from govuk-frontend have been moved to a separate file `es6-components.js` which is included in `application.html.erb` as a script tag with `type="module"`.
MartinJJones
force-pushed
the
use-govuk-frontend-v5
branch
from
e8eba12
to
9b96d8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
What
es6-components.jsfileWhy
govuk_publishing_components uses v5 of govuk-frontend. There are several breaking changes in this release and so we need to update the applications that use govuk_publishing_components. Please read what has changed in govuk_publishing_components and govuk-frontend. This specific changes this PR addresses are:
es6-components.jsfilegovuk-frontendloads a page with JS on it, attempting to parse the JS fromgovuk-frontendwill cause an error. To avoid this from happening, JS that containsgovuk-frontendJS has been moved to seperate file which will be loaded in a script tag withtype="module". This will prevent the JS from being parsed and so prevent the error$legacyattribute ingovuk-colourhas been deprecated and using it will have no effect (other than generating warnings on pre-compilation)$govuk-compatibility-govuktemplatehas been removed and using it will have no effect$govuk-new-link-stylesdoes not need to be setFollow these steps if you are doing a Rails upgrade.