Fix implementation record filtering #4533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the JS was using `innerText` but we include hidden elements to match the title of the sections on events by type, `innerText` is less reliable than `textContent` as it doesn't include hidden text
|
@AshGDS I guess I just found the value of having tests for our code... 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / why
Fix a small bug in the filtering functionality recently added to some pages in the implementation record.
The JS was using
innerTextbut we include hidden elements to match the title of the sections on events by type.innerTextis less reliable thantextContentas it doesn't include hidden text, and during testing it produced some slightly odd results. This change fixes them.Visual changes
None.
Trello card: https://trello.com/c/m6vL7lJy/186-add-filters-to-events-and-attributes-pages-on-implementation-record