Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add components to implementation record #4543

Merged
merged 1 commit into from Mar 6, 2024
Merged

Conversation

andysellick
Copy link
Contributor

What

In the GA4 implementation record, where an event occurs on a component, document and link to the component guide page for that component. This is done per-event, as some event groupings apply to more than one component.

Why

Part of improving the implementation record for users.

Visual changes

Screenshot 2024-03-06 at 09 31 08

- for the GA4 implementation record, where an event occurs on a component, document and link to the component guide page for that component
@andysellick andysellick requested a review from AshGDS March 6, 2024 09:32
Copy link
Contributor

@AshGDS AshGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 How does this work when the event applies to more than one component? E.g. the callout tracking would have worked on both the warning text component, and the govspeak component before I removed it from the govspeak component due to it affecting external links.

@andysellick
Copy link
Contributor Author

@AshGDS yeah I thought about that. I think if we encounter that in future we can either extend this functionality (so the component is a comma separated list or something) or separate the event out into two events.

There are some other slightly complicated things that I just decided were too nuanced for the purposes of this documentation. For example when we have attachments rendered inside govspeak - explaining how that all fits together for a non-technical audience seemed too much, so I just pointed it at the attachment component page instead.

@andysellick andysellick merged commit cc6fef7 into main Mar 6, 2024
7 checks passed
@andysellick andysellick deleted the imp-record-add-components branch March 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants