Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GA4 'filter' events to the analytics docs #4574

Merged
merged 2 commits into from Mar 22, 2024
Merged

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Mar 22, 2024

What

  • Adds the filter events to the docs
  • Adds the focus loss tracker to the docs
  • Updates the .gitignore as it tries to add node_modules to your commits and .DS_Store if you've ever worked with images in this repo

@AshGDS AshGDS self-assigned this Mar 22, 2024
@AshGDS AshGDS changed the title Ga4 add filter docs Add GA4 'filter' events to the analytics docs Mar 22, 2024
@AshGDS AshGDS requested a review from andysellick March 22, 2024 11:14
data/analytics/events.yml Show resolved Hide resolved
- name: filter search
implemented: true
priority: low
description: When a user searches for a link on a page, and the search box is one that filters all the results using CSS instead of HTTP or API requests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: When a search box is used to filter a long list of things on a page, by showing relevant matches using JavaScript, rather than fetching a new page of results from the server

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andysellick I was hesitant to just say JavaScript, since our finder searches use client side JavaScript to update search results. Given this, should I still use your suggestion?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about When a search box is used to filter a long list of things on a page, by hiding irrelevant matches, rather than fetching a new page of results from the server ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshGDS I think you might have updated the wrong bit - I meant this description for filter search. The description for filter link clicks could just be Link clicks in a filter search list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andysellick Sounds good 👍 Have updated both descriptions, should be ready for another review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, didn't see your latest comment - one second

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated now!

data/analytics/events.yml Outdated Show resolved Hide resolved
@AshGDS
Copy link
Contributor Author

AshGDS commented Mar 22, 2024

Thanks @andysellick - should be ready for another review 👍

@AshGDS AshGDS force-pushed the ga4-add-filter-docs branch 2 times, most recently from 033b28c to 8dc4982 Compare March 22, 2024 12:27
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@AshGDS AshGDS merged commit 27ad3f4 into main Mar 22, 2024
9 checks passed
@AshGDS AshGDS deleted the ga4-add-filter-docs branch March 22, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants