New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GA4 'filter' events to the analytics docs #4574
Conversation
data/analytics/events.yml
Outdated
- name: filter search | ||
implemented: true | ||
priority: low | ||
description: When a user searches for a link on a page, and the search box is one that filters all the results using CSS instead of HTTP or API requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: When a search box is used to filter a long list of things on a page, by showing relevant matches using JavaScript, rather than fetching a new page of results from the server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andysellick I was hesitant to just say JavaScript, since our finder searches use client side JavaScript to update search results. Given this, should I still use your suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about When a search box is used to filter a long list of things on a page, by hiding irrelevant matches, rather than fetching a new page of results from the server
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AshGDS I think you might have updated the wrong bit - I meant this description for filter search
. The description for filter link clicks
could just be Link clicks in a filter search list
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andysellick Sounds good 👍 Have updated both descriptions, should be ready for another review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, didn't see your latest comment - one second
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated now!
Thanks @andysellick - should be ready for another review 👍 |
033b28c
to
8dc4982
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
8dc4982
to
7dca7eb
Compare
What
.gitignore
as it tries to addnode_modules
to your commits and.DS_Store
if you've ever worked with images in this repo