Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test #3910

Merged
merged 1 commit into from Mar 11, 2024
Merged

Fix failing test #3910

merged 1 commit into from Mar 11, 2024

Conversation

andysellick
Copy link
Contributor

What / why

Fix intermittently failing tests in the cookie functions.

  • some of the tests in this file were intermittently failing (even only using specific seeds 51181 and 04195)
  • no cleanup was present for these tests, which now run alongside a lot more tests involving the single consent API, so it seems likely that uncleared cookies were causing this problem

Visual changes

None.

- some of the tests in this file were intermittently failing (even only using specific seeds 51181 and 04195)
- no cleanup was present for these tests, which now run alongside a lot more tests involving the single consent API, so it seems likely that uncleared cookies were causing this problem
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3910 March 11, 2024 14:23 Inactive
@andysellick andysellick merged commit 81a4223 into main Mar 11, 2024
12 checks passed
@andysellick andysellick deleted the fix-failing-test branch March 11, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants