Add GA4 developer guide #3919
Merged
Add GA4 developer guide #3919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Nice, LGTM 👍 Non-blocking but I did find the index_section and index_section_count definitions a bit hard to understand. Maybe it's worth rewording them. It might be worth providing a more visual example? For example <h2> elements are usually what determine our sections, so maybe if we had some HTML in the doc that shows a couple sections and then the GA4 attributes they have.
|
Thanks @AshGDS, good feedback. I'm keen to get this right before merging, so have rewritten that section slightly and added an example. Is it any clearer? Is this a good enough example? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a developer guide for GA4. Also separate the consent stuff out into its own page (so we can link to it more easily from the implementation record).
Why
There's some developer confusion around making changes to code containing tracking, this aims to improve understanding.
Visual Changes
None.