Add a new GA4 'focus loss' tracker #3920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
force-pushed
the
ga4-focus-loss-tracker
branch
from
87312cf
to
eb03d06
Compare
AshGDS
force-pushed
the
ga4-focus-loss-tracker
branch
from
eb03d06
to
0dcafac
Compare
AshGDS
force-pushed
the
ga4-focus-loss-tracker
branch
from
0dcafac
to
a0e9e4f
Compare
andysellick
approved these changes
Mar 15, 2024
| var element | ||
| var expected | ||
|
|
||
| function agreeToCookies () { |
There was a problem hiding this comment.
Non-blocking: I think we're using this kind of function in a few places now - worth raising an issue/adding a ticket to see if we can define it once in a helper somewhere instead of repeating it?
| @@ -740,7 +740,7 @@ describe('A specialist link tracker', function () { | |||
| }) | |||
|
|
|||
| afterEach(function () { | |||
| GOVUK.cookie('cookies_policy', null) | |||
| GOVUK.setCookie('cookies_policy', null) | |||
There was a problem hiding this comment.
I thought that .cookie and .setCookie were equivalent, is that not the case? Was this causing an error?
There was a problem hiding this comment.
My fault - saw it and thought it was a typo. Will revert
| @@ -0,0 +1,16 @@ | |||
| # Google Analytics 4 focus loss tracker | |||
There was a problem hiding this comment.
Good documentation. Can you include a link to it in ga4-all-trackers.md?
AshGDS
force-pushed
the
ga4-focus-loss-tracker
branch
from
a0e9e4f
to
b7e9b5d
Compare
AshGDS
force-pushed
the
ga4-focus-loss-tracker
branch
from
b7e9b5d
to
c4cad6f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ga4-focus-loss-trackerstaticand seems to be working as intendedWhy
keypress.Visual Changes
None.