Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GA4 callout tracking from the govspeak component #3946

Merged
merged 1 commit into from Mar 22, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Mar 22, 2024

What

  • Remove the callout tracking from the govspeak component (again)

Why

Visual Changes

None.

@AshGDS AshGDS requested a review from andysellick March 22, 2024 11:30
@AshGDS AshGDS self-assigned this Mar 22, 2024
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3946 March 22, 2024 11:31 Inactive
@AshGDS AshGDS changed the title Remove GA4 callout tracking from govspeak component Remove GA4 callout tracking from the govspeak component Mar 22, 2024
We have deemed this too fiddly to keep in
@AshGDS AshGDS force-pushed the ga4-remove-callout-tracking-again branch from d137bd2 to 09c7915 Compare March 22, 2024 11:31
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3946 March 22, 2024 11:32 Inactive
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - feels like a lot of back and forth on this bit of work, but well done for getting it this far.

@AshGDS AshGDS merged commit 1c7402e into main Mar 22, 2024
13 checks passed
@AshGDS AshGDS deleted the ga4-remove-callout-tracking-again branch March 22, 2024 12:28
@andysellick andysellick mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants