Fix anchoring in ID validation regex. #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ComponentWrapperHelper::check_id_is_valid` would erroneously accept an ID string that contained newlines. Fixes https://github.com/alphagov/govuk_publishing_components/security/code-scanning/8.
andysellick
reviewed
Mar 26, 2024
- Add a test case for invalid element IDs containing newlines. - Clean up the existing tests to remove some duplicated test cases (single responsibility principle for tests) and avoid change detecting on error message strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby regexes are — bizarrely — multiline by default, so
ComponentWrapperHelper::check_id_is_validwould have erroneously accepted an ID string that contained newlines.Fixes https://github.com/alphagov/govuk_publishing_components/security/code-scanning/8.
No visual changes. Should also be no functional change for normal usage.