Polymorphic attachments #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Nice work, and long overdue! 👍 I will say that we should definitely add a cucumber scenario to cover the happy path for adding an attachment. We were clearly too aggressive in our de-cuking during the last major refactor... |
|
Sure thing, on the cuke, but I wouldn't do it in this PR – the sooner this gets onto master the sooner people stop spending time dealing with the complexity… |
We've replaced all five of the separate join models (e.g. EditionAttachment and SupportingPageAttachment) with a polymorphic association.
The code that initiated the behaviour in Admin::AttachmentActionParamHandler was duplicated across three controllers, making it easy to fail to update one of them when the behaviour changed. This commit dries it up, so any controller that includes the module only needs to call it in a before filter.
|
Rebasing with master... |
tekin
added a commit
that referenced
this pull request
Sep 23, 2013
Tracker: https://www.pivotaltracker.com/story/show/57303956 Polymorphic attachments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://www.pivotaltracker.com/story/show/57303956