Remove worldwide organisation field from role edit view when feature flag enabled #9043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
remove-legacy-role-ww-org
branch
from
1792639
to
90f4154
Compare
brucebolt
changed the title
brucebolt
force-pushed
the
remove-legacy-role-ww-org
branch
2 times, most recently
from
73fb5f4
to
ee249d7
Compare
For Editionable Worldwide Organisations, we are assigning roles to them through the editionable user interface and through the `EditionRole` relationship. However the non-editionable version of Worldwide Organisations has them assigned on the role user interface and through the `WorldwideOrganisationRole` relationship. Therefore disabling the non-editionable way of assigning roles when the editionable worldwide organisation feature flag is enabled.
brucebolt
force-pushed
the
remove-legacy-role-ww-org
branch
from
ee249d7
to
9ec8ed8
Compare
Gweaton
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Editionable Worldwide Organisations, we are assigning roles to them through the editionable user interface and through the
EditionRolerelationship.However the non-editionable version of Worldwide Organisations has them assigned on the role user interface and through the
WorldwideOrganisationRolerelationship.Therefore disabling the non-editionable way of assigning roles when the editionable worldwide organisation feature flag is enabled.
Trello card