Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated extended_dump option #266

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

airlaser
Copy link

Resolves #265

Extended dump was made obsolete by the change to GraphQL and is no longer useful. The variable is not used outside of being assigned.

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #266 into master will decrease coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   80.08%   79.64%   -0.44%     
==========================================
  Files          16       16              
  Lines         959      958       -1     
  Branches      131      131              
==========================================
- Hits          768      763       -5     
- Misses        151      158       +7     
+ Partials       40       37       -3
Impacted Files Coverage Δ
instalooter/cli/constants.py 83.33% <ø> (ø) ⬆️
instalooter/cli/__init__.py 62.71% <ø> (ø) ⬆️
instalooter/batch.py 81.57% <ø> (ø) ⬆️
instalooter/looters.py 73.45% <ø> (-1.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0001e32...8b4b9a2. Read the comment docs.

@althonos
Copy link
Owner

Thanks! I'll merge, but this will require a new major release (the fix is a breaking change) so it may take some time before I actually push it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What does extended_dump actually do?
2 participants