Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to angular 9 #68

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

obsd
Copy link

@obsd obsd commented Jun 2, 2020

No description provided.

bsd added 2 commits May 25, 2020 07:51
fix fsenvets to work with node 12
@alvarotrigo
Copy link
Owner

Thanks for that @obsd !
One question tho, it seems you are removing the polyfills.ts file but then you keep including it on tsconfig.app.json. Is that correct?

  "files": [
    "test.ts",	    "main.ts",
    "**/*.spec.ts"	    "polyfills.ts"
  ],

@alvarotrigo alvarotrigo changed the base branch from master to dev June 2, 2020 09:16
@obsd
Copy link
Author

obsd commented Jun 11, 2020

Thanks for that @obsd !
One question tho, it seems you are removing the polyfills.ts file but then you keep including it on tsconfig.app.json. Is that correct?

  "files": [
    "test.ts",	    "main.ts",
    "**/*.spec.ts"	    "polyfills.ts"
  ],

The remove is angular auto-upgrade, so probably we should remove it from ts config as well, do you want me to do it?

@alvarotrigo
Copy link
Owner

That'd be great thanks! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants