#1381 Split up describe_combat() #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /* First we need to look for extra blows on other items, as | ||
| * state does not track these */ | ||
| for (int i = INVEN_BOW; i < INVEN_TOTAL; i++) |
There was a problem hiding this comment.
You can't do this in Angband - we use C89. So all declarations inside the for () loop need moving to the top of the function.
There was a problem hiding this comment.
Ok, I'll fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1381 Split up describe_combat()
The function was split into three
by creating two new functions:
describe_blows and describe_damage.
Changes in:
obj-info.c
Note: The new functions have been tested with several
artifacts, and seem to describe them correctly when the
command 'I' for examining an item is given. Comparisons
were made by running two games at the same time, side by
side, one with the original code and one with the changed
code.