Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrolling with large amount of columns,columns disappear after sort #2357

Closed
gotenxds opened this issue Dec 16, 2014 · 7 comments
Closed

scrolling with large amount of columns,columns disappear after sort #2357

gotenxds opened this issue Dec 16, 2014 · 7 comments

Comments

@gotenxds
Copy link

Hi,
In the demo application I move the scrollbar to last column "coll499" when i click on the column header
to sort the data,the column disappaer
the grid before i clicked
image
after the click
image
I am trying this from the this url! from ui-grid website.

note:in my project its also disappear when try to edite the one of the last few column
@c0bra c0bra closed this as completed in bc2c68a Dec 16, 2014
@jcompagner jcompagner mentioned this issue Dec 17, 2014
Closed
jcompagner added a commit to Servoy/ng-grid that referenced this issue Dec 17, 2014
@jcompagner
regression fix for: angular-ui#2357 scrolling with large amount of co…
b75df2f 
…lumns,columns

disappear after sort 

scrollTop can now be undefined/null then that value should not be used
for calculating if this is a scroll that doesn't have to update
anything.
jcompagner added a commit to Servoy/ng-grid that referenced this issue Dec 17, 2014
@jcompagner
regression fix for: angular-ui#2357 scrolling with large amount of co…
608cd77 
…lumns,columns

disappear after sort 

scrollTop can now be undefined/null then that value should not be used
for calculating if this is a scroll that doesn't have to update
anything.
PaulL1 added a commit that referenced this issue Dec 19, 2014
@PaulL1
Merge pull request #2379 from Servoy/row_inserts_before_current_fix
82074e8 
regression fix for: #2357 scrolling with large amount of columns,columns disappear after sort
jcompagner added a commit to Servoy/ng-grid that referenced this issue Dec 23, 2014
@jcompagner
Regression Fix for angular-ui#2357 the scrollPercentage is not correc…
651e738 
…t if there

are added rows, because then the scrollPercentage should be
recalculated.
@jcompagner
Copy link
Contributor

this fix has a side effect that when new rows are coming in the old scrollPercentage was used. So the screen is getting blank you can see that in the current example of http://ui-grid.info/docs/#/tutorial/212_infinite_scroll

i created a patch for this: #2425 but i guess we need to test if this does not undo the fix for this case (its now an option what to send, so that or the previoussScrolToplPercentage is used or the previousScrollTop and modifyRows call will say that it should use the previousScrollTop because the added rows could result in a completely different percentage

@c0bra
Copy link
Contributor

c0bra commented Dec 23, 2014

I believe I already committed a fix for this.

@jcompagner
Copy link
Contributor

which commit was that? And should that be already in the demo's like the infinit scroll i pointed to above?
Because currently (29 december) it doesn't work yet. Infinite scroll is still broken

@c0bra
Copy link
Contributor

c0bra commented Dec 29, 2014

You're correct; my "fix" broke infinite scrolling (oops). Thanks for the PR, I will check it out.

jcompagner added a commit to Servoy/ng-grid that referenced this issue Jan 6, 2015
@jcompagner
Regression Fix for angular-ui#2357 the scrollPercentage is not correc…
e497eac 
…t if there

are added rows, because then the scrollPercentage should be
recalculated.
c0bra pushed a commit that referenced this issue Feb 19, 2015
@jcompagner @c0bra
fix(Grid): Redraw needs scrollTop when adding rows
509e007 
Regression Fix for #2357 the scrollPercentage is not correct if there
are added rows, because then the scrollPercentage should be
recalculated.
@leo009394
Copy link

hi @c0bra
I still have found the same issue when a cell is in edit. Have you fixed this issue or I missed something.
You can try in the plunker bellow, scroll grid to the right and try edit a cell.
Here is the plunker

@stefan-leye
Copy link

I have the same issue

@Niranthari
Copy link

hi @c0bra i still have the issue regarding the scroll bar disappears while i am trying to edit the cell could you pls help me.its very urgent.Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@c0bra @jcompagner @gotenxds @leo009394 @stefan-leye @Niranthari