Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($location): absUrl() does not return undefined for base href and … #14085

Closed
wants to merge 1 commit into from

Conversation

rvpatkar
Copy link

…html5Mode

$location's absUrl incorrectly returned undefined when using base href and html5Mode. Initializaing it to fix this issue.

Closes #11091

…html5Mode

$location's absUrl incorrectly returned undefined when using base href and html5Mode. Initializaing it to fix this issue.

Closes angular#11091
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@rvpatkar
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@gkalpak
Copy link
Member

gkalpak commented Feb 19, 2016

Thx for the PR, but there needs to be at least one test (verifying the fix and guarding against future regressions), before we can merge this.

TBH, I'm not even sure what issue this PR fixes.

@gkalpak
Copy link
Member

gkalpak commented Jun 3, 2016

Closing in favor of #14488 (which also includes a test).

@gkalpak gkalpak closed this Jun 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$location.absUrl() returns undefined with base href and html5Mode
3 participants