Delete multiple videos at once #756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/ui/src/main/res/values/strings.xml
|
@Yashraj254, thank you for the pull request, and I'm sorry for not getting back to you sooner. Your work looks really good. I have a small suggestion regarding the user interface: instead of using square checkboxes, could you use circular ones? Also, for items that are not selected, we don't need any checkbox at all. Additionally, I think it would improve the appearance if we added a highlighted background for selected videos to make them more noticeable. |
|
It's alright, I will implement those changes. In the meantime, could you please review my other PRs? |
|
Does this look better or should i use a different color, any suggestions? sample2.mp4 |
|
This is a very useful feature, but its not available yet in the main build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #688 featured added: select multiple videos for deletion
Record_2023-11-17-14-27-31.1.mp4