Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Edit Address Text field to also take special characters #1037

Open
4 tasks
keshakaneria opened this issue Aug 25, 2020 · 19 comments · May be fixed by #1149
Open
4 tasks

Edit Address Text field to also take special characters #1037

keshakaneria opened this issue Aug 25, 2020 · 19 comments · May be fixed by #1149
Assignees
Labels
Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Open Source Hack Type: Bug Bug or Bug fixes.

Comments

@keshakaneria
Copy link
Member

Description

In the address field, the text is not allowed to enter the symbolic values like ,, ., /, -. Add appropriate changes to field along with consistency in database to allow user to insert address having these symbols.

Acceptance Criteria

Update [Required]

  • User should be able to input address in any desired form
  • Consistency with database should me maintained

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

2 hours

@keshakaneria keshakaneria changed the title Edit Address Text field to also take special characters like (‘,’ ,’.’, ’/’, ’-’) Edit Address Text field to also take special characters Aug 25, 2020
@keshakaneria keshakaneria added Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Open Source Hack Type: Bug Bug or Bug fixes. labels Aug 25, 2020
@ankita1964
Copy link

Hey @keshakaneria I would like to work on this issue.

@keshakaneria
Copy link
Member Author

@ankita1964 Once the OSH event gets started, I'll assign you to work on. Till then go through the codebase and have installation ready locally :)

@vaibhavarora102
Copy link
Contributor

@keshakaneria i wiould also like to work

@vaibhavarora102
Copy link
Contributor

Hi, can you pls assign this issue to me as its already 1st of September and I guess OSH has started
Thanks

@keshakaneria
Copy link
Member Author

@vaibhavarora102 Will assign you once there is inactivity for 3 days to the assigned person who commented first.

@ashwinitanpure
Copy link

@keshakaneria could you assign this issue to me? I would like to work on this.

@keshakaneria
Copy link
Member Author

@keshakaneria could you assign this issue to me? I would like to work on this.

This issue is already assigned. If the person will not continue for 3 days the next interested person will be assigned.

@HariniJeyaraman
Copy link

@keshakaneria I don't have any issues assigned yet. Would love to work on this issue

@keshakaneria
Copy link
Member Author

@vaibhavarora102 are you assigned any issues? or should I proceed to give others this chance?

@vaibhavarora102
Copy link
Contributor

No I am free all work is done kindly assign me

@PrernaSingh587
Copy link

@vaibhavarora102 are you working on this issue?

@vaibhavarora102
Copy link
Contributor

Yes give some time pls

@keshakaneria
Copy link
Member Author

Yes give some time pls

It's already assigned to since 3 days. You have to keep us updated with the work you are doing. Being inactive for 3 days will make someone else assign this issue.

@vaibhavarora102
Copy link
Contributor

hi, can you pls tell which file is needed to be changed

@keshakaneria
Copy link
Member Author

hi, can you pls tell which file is needed to be changed

You can look at the models.py in administration folder if you want to explore where and how it is working.

@vaibhavarora102
Copy link
Contributor

hi @keshakaneria
i had opened a pull request, build has failed by bot
can you pls tell what exactly has happened

@vaibhavarora102 vaibhavarora102 linked a pull request Oct 5, 2020 that will close this issue
4 tasks
@vaibhavarora102
Copy link
Contributor

@keshakaneria hi had opened new pr
kindly consider that

as while squashing i did some wrong steps due to which it created everything mesy.

i had as it is copied changes from previous or #1149

kindly do consider this

@emmanuelhashy
Copy link

@keshakaneria I'd like to work on this.

@keshakaneria
Copy link
Member Author

@keshakaneria I'd like to work on this.

Hey @emmanuelhashy, good to see your interest for contribution. Since there is already a PR opened for this issue, I would like you to search for other open issues. There are a plenty of them where you can choose one and start contributing. If you find any difficulty, do ping us :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Open Source Hack Type: Bug Bug or Bug fixes.
Projects
None yet
7 participants